shared-bindings: Update DigitalIO.pull docs and validate that third state.#188
Merged
Conversation
state is None and not anything. Fixes micropython#187
dhalbert
approved these changes
Aug 22, 2017
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
great! I have never seen "pull" used as a noun about pins, so I am thinking in the long run to change the doc a bit so to refer to pull-ups and pull-downs (with or without hyphens), but that's for later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That way other values besides None throw errors instead of acting like None.
Fixes #187