Skip to content

Validate portions of mpy load to detect corruption#1971

Closed
tannewt wants to merge 1 commit into
adafruit:4.0.xfrom
tannewt:validate_mpy_load
Closed

Validate portions of mpy load to detect corruption#1971
tannewt wants to merge 1 commit into
adafruit:4.0.xfrom
tannewt:validate_mpy_load

Conversation

@tannewt
Copy link
Copy Markdown
Member

@tannewt tannewt commented Jun 25, 2019

Fixes #1917

@tannewt tannewt added this to the 4.x.x - Bug fixes milestone Jun 25, 2019
@tannewt tannewt requested a review from dhalbert June 25, 2019 22:43
@tannewt
Copy link
Copy Markdown
Member Author

tannewt commented Jun 26, 2019

Nulls are valid in QSTR so going back to the drawing board.

@tannewt tannewt closed this Jun 26, 2019
klardotsh pushed a commit to klardotsh/circuitpython that referenced this pull request Aug 11, 2019
If tcp_write returns ERR_MEM then it's not a fatal error but instead means
the caller should retry the write later on (and this is what lwIP's netconn
API does).

This fixes problems where a TCP send would raise OSError(ENOMEM) in
situations where the TCP/IP stack is under heavy load.  See eg issues adafruit#1897
and adafruit#1971.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant