Skip to content

nrf: Enable the adafruit_hid modules on nrf boards#2051

Closed
jepler wants to merge 1 commit into
adafruit:masterfrom
jepler:nrf-hid
Closed

nrf: Enable the adafruit_hid modules on nrf boards#2051
jepler wants to merge 1 commit into
adafruit:masterfrom
jepler:nrf-hid

Conversation

@jepler
Copy link
Copy Markdown

@jepler jepler commented Aug 10, 2019

Cross-platform bugs aside (#2048) this seems to work, and there's plenty of room available.

Cross-platform bugs aside (adafruit#2048) this seems to work, and there's plenty
of room available.
Copy link
Copy Markdown

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically don't freeze modules unless absolutely necessary. In theory, the nRF boards should have enough space to not warrant frozen modules. @tannewt Thoughts?

@dhalbert
Copy link
Copy Markdown
Collaborator

Right, don’t need to freeze unless there are RAM space issues.

@tannewt
Copy link
Copy Markdown
Member

tannewt commented Aug 12, 2019

Yup, closing since we don't need the RAM saved by freezing. Leaving it outside the binary makes it much easier to update.

@tannewt tannewt closed this Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants