Add GD25Q32C flash device definition#2105
Merged
Merged
Conversation
Collaborator
Author
|
The build failed but that doesn't seem to be my code's fault 😅 |
Collaborator
|
@arturo182 I simulated the build on my own machine and didn't see this issue. I re-ran the build a couple of times and now it's failing even earlier, not being able to find a commit. I'd guess there are some issues on the GitHub Actions side; we can try again in the morning. |
Collaborator
Author
|
No worries, this is not a high prio commit, just wanted to have it here so I don't lose track of it :) |
The GitHub Actions build for this PR is failing for reasons that make no sense. Make a tiny commit change to see if it will refresh things and work again.
dhalbert
approved these changes
Sep 3, 2019
Collaborator
|
I tried re-rerunning this morning and the check-run again failed trying to find a commit. I made a trivial typo fix to force a new commit and new check run, and it worked. |
Collaborator
|
Thank you for the addition! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with a board I'm working on :)