Enable float instructions support for asm_thumb#2276
Closed
gpshead wants to merge 1 commit into
Closed
Conversation
Author
|
LOL... examining things, this doesn't look needed anymore. py/mpconfig.h now auto-defines this one. (ISTR that wasn't the case a year or two back). closing. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hot on the heels of #2271, enable floating point instruction support when
@micropython.asm_thumbis enabled.This blindly assumes CIRCUITPY_ENABLE_MPY_NATIVE is only likely to be specified on boards with more ram which to me implies m4 which implies hardware floating point.
If native is desired on lesser boards (will it reasonably fit there?), we'd need to plumb through a conditional about that to && into the define. I didn't see an obvious existing define, just a soft-float compiler flag, so I'm not trying to plumb that in pre-emptively.