Re-initialize ADC before every AnalogIn read.#255
Merged
Conversation
`microcontroller.cpu.temperature` uses different ADC settings, and caused AnalogIn to give wrong answers. AnalogIn can no longer assume it's the only user of the ADC.
tannewt
approved these changes
Sep 16, 2017
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
This works for me! Please merge it into the 2.x branch too. We'll need to redo it for ASF4 so lets not put a bunch of time into it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
microcontroller.cpu.temperatureuses different ADC settings, and causedAnalogIn to give wrong answers. AnalogIn can no longer assume it's the
only user of the ADC.
This fixes #253, at the expense of re-initing the ADC on every read, and also doing double reads to ensure accuracy of the result.
A more sophisticated implementation would remember the last ADC settings and not re-init if they were the same. If we're not going to do that, the AnalogIn code could be simplified to not save the ADC structs on the heap, but simply re-create them each time.
@tannewt -- do you have an opinion? Maybe it's not worth cleaning up because it will all change with ASF4.