Skip to content

PacketBuffer.packet_size was returning bool instead of int#2554

Merged
tannewt merged 1 commit into
adafruit:masterfrom
dhalbert:packetbuffer-packet_size
Jan 29, 2020
Merged

PacketBuffer.packet_size was returning bool instead of int#2554
tannewt merged 1 commit into
adafruit:masterfrom
dhalbert:packetbuffer-packet_size

Conversation

@dhalbert
Copy link
Copy Markdown
Collaborator

@dhalbert dhalbert commented Jan 27, 2020

  • Fix return value for PacketBuffer.packet_size
  • Fix some documentation issues. It doesn't seem possible to use backticks in function signatures: they get included literally in the signature. If you know how to fix this let me know.

@dhalbert dhalbert requested a review from tannewt January 27, 2020 22:12
tannewt
tannewt approved these changes Jan 27, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! I don't know how the ticks work. Feel free to merge after the CI is happy.

@tannewt tannewt merged commit 7d4f9fc into adafruit:master Jan 29, 2020
@dhalbert dhalbert deleted the packetbuffer-packet_size branch January 31, 2020 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tannewt tannewt tannewt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dhalbert @tannewt