Ohs2020 badge updates#2575
Closed
mwelling wants to merge 9 commits into
Closed
Conversation
added 4 commits
February 1, 2020 17:23
We had the pin names swapped on the schematic and a different flash was populated. Signed-off-by: Michael Welling <mwelling@ieee.org>
The backlight enable is active low on our board so the driver doesn't like it. Toggling to GPIO manually for now. As fixed the improper SPI bus pins definitions and it works! Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Michael Welling <mwelling@ieee.org>
…20-badge Signed-off-by: Michael Welling <mwelling@ieee.org>
Member
|
hi i think you have to rebase and update all the submodules so your PR is just code? |
added 5 commits
February 2, 2020 21:52
We had the pin names swapped on the schematic and a different flash was populated. Signed-off-by: Michael Welling <mwelling@ieee.org>
The backlight enable is active low on our board so the driver doesn't like it. Toggling to GPIO manually for now. As fixed the improper SPI bus pins definitions and it works! Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Michael Welling <mwelling@ieee.org>
Make to go faster I guess. Signed-off-by: Michael Welling <mwelling@ieee.org>
…on into ohs2020-badge
Author
|
Crap I did that wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes registration for QSPI, I2C and SPI.