Make particle Xenon analog RGB LED available to user#2803
Closed
iayanpahwa wants to merge 1 commit into
Closed
Conversation
Member
|
I don't want to lose the status functionality. To provide user access we should add custom exceptions to "busy pin" detection like we do for neopixel. https://github.com/adafruit/circuitpython/blob/master/ports/nrf/common-hal/microcontroller/Pin.c#L97 |
Author
|
Thanks @tannewt I will look at that approach |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Particle Xenon has an on-board analog RGB LED but .with it's current configuration in CircuitPython it is not available to user.
`
It is understandable that this RGB LED could have been used to show bootloader status but it doesn't follow the standard set by CircuitPython project, making it unusable and not to mention it stays on all the time with some weird colour (power usage) ,
So IMHO it is a good idea to rather make this LED available to user within CircuitPython.
Fix tested on top of release 5.2.0
`