Skip to content

Add board file for the hacked Trinket M0 Express#303

Merged
tannewt merged 4 commits into
adafruit:2.xfrom
pypewpew:trinket-m0-express
Oct 3, 2017
Merged

Add board file for the hacked Trinket M0 Express#303
tannewt merged 4 commits into
adafruit:2.xfrom
pypewpew:trinket-m0-express

Conversation

@deshipu
Copy link
Copy Markdown

@deshipu deshipu commented Oct 2, 2017

@deshipu
Copy link
Copy Markdown
Author

deshipu commented Oct 2, 2017

I'm not sure if this is actually useful, but since I got it working, I thought I would make the pull request anyways.

@tannewt
Copy link
Copy Markdown
Member

tannewt commented Oct 2, 2017

Thanks for this! I'm not exactly sure how we want to handle the branding for this since its a hacked up Trinket. I think it'd be ok to have it pulled in. We just likely want to caveat it.

Copy link
Copy Markdown
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this! I'd love to have it pulled in. I don't think we should call it Trinket M0 Express because it sounds too officially sactioned. What do you think about calling it Trinket M0 Haxpress? That makes it clearer its a hack :-)

#endif

#ifndef USB_DEVICE_PRODUCT_NAME
# define USB_DEVICE_PRODUCT_NAME "Trinket M0"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Trinket M0 Haxpress"


//! USB Device string definitions (Optional)
#ifndef USB_DEVICE_MANUFACTURE_NAME
# define USB_DEVICE_MANUFACTURE_NAME "Adafruit Industries"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to make it clear its not officially sanctioned.

@@ -0,0 +1,39 @@
#define USB_REPL

#define MICROPY_HW_BOARD_NAME "Adafruit Trinket M0 Express"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this too.

@deshipu
Copy link
Copy Markdown
Author

deshipu commented Oct 3, 2017

Done. I hope I didn't miss any. I also changed one "micropython" to "circuitpython" — you might want to do that in other boards too.

@tannewt
Copy link
Copy Markdown
Member

tannewt commented Oct 3, 2017

Thanks @deshipu !

Which MicroPython did you change?

@tannewt tannewt merged commit c2bb9e2 into adafruit:2.x Oct 3, 2017
@deshipu
Copy link
Copy Markdown
Author

deshipu commented Oct 3, 2017

@tannewt
Copy link
Copy Markdown
Member

tannewt commented Oct 3, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants