Skip to content

atmel-samd: Re-enable pin reset. Fixes #352 #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhalbert merged 1 commit into from
Oct 20, 2017
Merged

atmel-samd: Re-enable pin reset. Fixes #352 #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion atmel-samd/common-hal/microcontroller/Pin.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ void reset_all_pins(void) {
pin_mask[0] &= ~(PORT_PA31);
#endif

//gpio_set_port_direction(GPIO_PORTA, pin_mask[0] & ~MICROPY_PORT_A, GPIO_DIRECTION_OFF);
gpio_set_port_direction(GPIO_PORTA, pin_mask[0] & ~MICROPY_PORT_A, GPIO_DIRECTION_OFF);
gpio_set_port_direction(GPIO_PORTB, pin_mask[1] & ~MICROPY_PORT_B, GPIO_DIRECTION_OFF);
#if PORT_BITS > 64
gpio_set_port_direction(GPIO_PORTC, pin_mask[2] & ~MICROPY_PORT_C, GPIO_DIRECTION_OFF);
Expand Down
5 changes: 3 additions & 2 deletions atmel-samd/supervisor/port.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
#include "hpl/gclk/hpl_gclk_base.h"
#include "hpl/pm/hpl_pm_base.h"

#include "common-hal/microcontroller/Pin.h"
#include "tick.h"

extern volatile bool mp_msc_enabled;
Expand Down Expand Up @@ -196,8 +197,8 @@ void reset_port(void) {
// // Wait for the DAC to sync then reset.
// while (DAC->STATUS.reg & DAC_STATUS_SYNCBUSY) {}
// DAC->CTRLA.reg |= DAC_CTRLA_SWRST;
//
// reset_all_pins();

reset_all_pins();
//
//
// usb_hid_reset();
Expand Down