Skip to content

Improve USB#373

Merged
dhalbert merged 2 commits into
adafruit:masterfrom
tannewt:check_cdc_status
Oct 26, 2017
Merged

Improve USB#373
dhalbert merged 2 commits into
adafruit:masterfrom
tannewt:check_cdc_status

Conversation

@tannewt
Copy link
Copy Markdown
Member

@tannewt tannewt commented Oct 26, 2017

There were a couple problems:

  1. The CDC code blocked when trying to transmit when no terminal software was connected on the other end reading.
  2. ASF4 replied with a fake inquiry result for the missing disk. Its changed to support returning null to ERR_ABORTED to indicate missing disks.

@tannewt tannewt requested a review from dhalbert October 26, 2017 00:55
dhalbert
dhalbert approved these changes Oct 26, 2017
View reviewed changes
Copy link
Copy Markdown
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!!

@dhalbert dhalbert merged commit d613776 into adafruit:master Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tannewt @dhalbert