Skip to content

Enable LONGINT on M4 + usb fix#391

Merged
dhalbert merged 3 commits into
adafruit:masterfrom
tannewt:longint_usb_fix
Nov 1, 2017
Merged

Enable LONGINT on M4 + usb fix#391
dhalbert merged 3 commits into
adafruit:masterfrom
tannewt:longint_usb_fix

Conversation

@tannewt
Copy link
Copy Markdown
Member

@tannewt tannewt commented Oct 31, 2017

No description provided.

I believe the issue was that LTO exacerbates a problem where a CDC
read is initiated but fails and leaves pending_read true
preventing further reads.
@tannewt tannewt added this to the 3.0 Beta milestone Oct 31, 2017
@tannewt tannewt requested a review from dhalbert October 31, 2017 22:49
dhalbert
dhalbert previously approved these changes Nov 1, 2017
Copy link
Copy Markdown
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are great, but travis is failing. I restarted it once and it's still failing, but I don't understand what's wrong -- it's not a typical failure. If you can fix or it's red herring feel free to finish merge.

@tannewt
Copy link
Copy Markdown
Member Author

tannewt commented Nov 1, 2017

I'll look tomorrow. Thanks!

This allows mpconfigport.mk to set this conditionally based on
$(CHIP_FAMILY).
@dhalbert dhalbert merged commit 3b17980 into adafruit:master Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants