Skip to content

atmel-samd: Stop double CSW after MSC reads#405

Merged
dhalbert merged 1 commit into
adafruit:masterfrom
tannewt:remove_double_csw
Nov 4, 2017
Merged

atmel-samd: Stop double CSW after MSC reads#405
dhalbert merged 1 commit into
adafruit:masterfrom
tannewt:remove_double_csw

Conversation

@tannewt
Copy link
Copy Markdown
Member

@tannewt tannewt commented Nov 3, 2017

This explicit zero length xfer leads to a second CSW packet. If
another read was started between the two CSWs then the host gets
confused and resets the device.

On reads, the CSW is automatically sent when we reply with the
total length. Writes must do it manually so they can wait for the
disk to flush the data.

This explicit zero length xfer leads to a second CSW packet. If
another read was started between the two CSWs then the host gets
confused and resets the device.

On reads, the CSW is automatically sent when we reply with the
total length. Writes must do it manually so they can wait for the
disk to flush the data.
@tannewt tannewt requested a review from dhalbert November 3, 2017 22:11
@tannewt tannewt added this to the 3.0 Beta milestone Nov 3, 2017
Copy link
Copy Markdown
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!! Great debugging !!

@dhalbert dhalbert merged commit 5ff6417 into adafruit:master Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants