atmel-samd: USB mass storage tweaks. #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Be more liberal with critical sections to ensure ordering. * Correct usb_busy so that it is busy when no errors occur on transfer. I believe it worked before because it would be false momentarily until a second transfer was attempted and a busy error was returned, therefore setting usb_busy to true. That risks the first "failed" transfer completing before a second one is attempted.
tannewt
changed the title
|
@tannewt Is there any conflict between turning the caches and the errata 1.6 regarding the DSU CRC32 which may fail if NVM caches are disabled? Does this apply? |
|
I don't think we're checking the CRC32 anywhere. We probably should though. |
|
Not with the cache disabled ;-) - Thanks for clarifying - I just wanted to make sure one fix was not going to introduce another latent bug. |
|
Yup, I appreciate the second set of eyes on it. |
dhalbert
added a commit
that referenced
this pull request
Nov 9, 2017
Unrevert the revert below, in preparation for PR #425 (tannewt/circuitpython, align_usb branch).
dhalbert
approved these changes
Nov 9, 2017
There was a problem hiding this comment.
@kattni and @hukuzatuna have tested this. I've tried it on Windows and it seems to be fine (not sure why my testing earlier seemed to point to an issue).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.