Adalogger m0 fixes#461
Merged
Merged
Conversation
- Added D4 and moved associated SD_CS so that they are paired within list - Added D7 and SD_CD which is the SD Card Detect pin - Added D8 and GREEN_LED - Added RED_LED associated with D13
…pdated pins.c - Added D4 and moved associated SD_CS so that they are paired within list - Added D7 and SD_CD which is the SD Card Detect pin - Added D8 and GREEN_LED - Added RED_LED associated with D13 - Added Setup information regarding arm complier packages - [skip ci] doc not code
…orted - [skip ci] doc not code
tannewt
requested changes
Nov 26, 2017
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
One change on the README. Thanks again!
| sudo dpkg --add-architecture i386 | ||
| sudo apt-get update -qq || true | ||
| sudo apt-get install -y python3 gcc-multilib pkg-config libffi-dev libffi-dev:i386 qemu-system gcc-mingw-w64 | ||
| sudo apt-get install -y --force-yes gcc-arm-embedded |
Member
There was a problem hiding this comment.
I don't think the middle three are actually required. Please also remove the -y and --force-yes arguments since these will be manually run.
- Setup information regarding arm complier packages was cleaned up - [skip ci] doc not code
Author
|
Updated as requested |
This was referenced Nov 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code and documentation fixes for #323 and #317 on 2.x:
atmel-samd/boards/feather_m0_adalogger/pins: Added missing pins
atmel-samd/README:
Added D4 and moved associated SD_CS so that they are paired within list
Added D7 and SD_CD which is the SD Card Detect pin
Added D8 and GREEN_LED
Added RED_LED associated with D13
Added Setup information regarding arm complier packages
README:
Updated to reflect that feather_m0_adalogger microSD is supported