Add the return value for the set_next_stack_limit function referenced…#5433
Add the return value for the set_next_stack_limit function referenced…#5433spencer-burke wants to merge 1 commit into
Conversation
… in adafruit#4520 Changes to be committed: modified: shared-bindings/supervisor/__init__.c
|
I have made a change and created the pr, if you would like me to write some tests of some kind I would be happy to. |
microdev1
left a comment
microdev1
left a comment
There was a problem hiding this comment.
Thanks for the PR @spencer-burke.
I don't think this resolves issue #4520. The stack size is set on the next VM run so with the function call there isn't a way to confirm whether the requested stack_limit is used or the default_limit is used.
I think changing the function name to something more appropriate like set_next_stack_limit_maybe should be enough here. This will result in a breaking change and the PR will have to be considered for 8.0.0 rather than merging it now
|
Alright, I will revert the changes I have made, and change the function name. |
|
I don't think it's helpful to return the passed in value. Thanks for the PR anyway! |
3 participants
… in #4520
Changes to be committed:
modified: shared-bindings/supervisor/init.c