Skip to content

MKR Zero: Remove rainbowio to save some space#5525

Closed
stonehippo wants to merge 1 commit into
adafruit:mainfrom
stonehippo:mkrzero_remove_rainbowio
Closed

MKR Zero: Remove rainbowio to save some space#5525
stonehippo wants to merge 1 commit into
adafruit:mainfrom
stonehippo:mkrzero_remove_rainbowio

Conversation

@stonehippo
Copy link
Copy Markdown

The MKR Zero has a pretty small internal flash, so reducing the size of the core CircuitPython build is ideal. Rainbowio has been removed from some other SAM21 boards without external flash, so doing that here, too.

The MKR Zero has a pretty small internal flash, so reducing the size of the core CircuitPython build is ideal. Rainbowio has been removed from some other SAM21 boards without external flash, so doing that here, too.
@dhalbert
Copy link
Copy Markdown
Collaborator

We didn't remove this on MKR Zero before, because it wasn't necessary to get it to fit with all translations. We are not seeing build failures right now with this board without the removal. What necessitated this for you? Thanks.

@dhalbert
Copy link
Copy Markdown
Collaborator

We hope to turn rainbowio back on, on the boards where we turned it off, after some space saving happens. Turning it off was only for expediency to get the release out.

@stonehippo
Copy link
Copy Markdown
Author

stonehippo commented Oct 29, 2021

@dhalbert I was in the process of making a custom build (to fit audiobusio and audioio onto the MKR Zero for I2S) and I noticed that rainbowio had been removed from several of the other SAM21 boards. I've been using a couple of these boards for messing with some I2C stuff as well, and there hasn't been a lot of space for libraries.

That said, I can see why you'd want to get rainbowio back on all boards for baseline consistency in CP.

I'll close this one.

@stonehippo stonehippo closed this Oct 29, 2021
@stonehippo stonehippo deleted the mkrzero_remove_rainbowio branch October 29, 2021 13:54
@dhalbert
Copy link
Copy Markdown
Collaborator

NP - In 8.0.0 we will be able to remove some things, such as OneWire being in both onewireio (new location) and busio (old location), and that should free up the space we need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants