Update xiao rp2040 pins#5693
Closed
prplz wants to merge 0 commit into
Closed
Conversation
|
If these are the components of an RGB LED, and not independent "red LED", "green LED" and "blue LED", I believe it is customary to call the components circuitpython/ports/raspberrypi/boards/pimoroni_tiny2040/pins.c Lines 15 to 17 in 8eee16c |
dhalbert
requested changes
Dec 9, 2021
Collaborator
|
@prplz could you checkout |
7c8c4dc to
1aa51c6
Compare
Author
|
Oops, force push made stuff go a little weird. |
1aa51c6 to
6e440e7
Compare
6e440e7 to
5ea4082
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schematic on the seeed website is incorrect/outdated. In reality there's an RGB LED connected to the pins as specified in this PR.
Tested on real hardware.