Skip to content

Update xiao rp2040 pins#5693

Closed
prplz wants to merge 0 commit into
adafruit:mainfrom
prplz:xiao-rp2040-pins
Closed

Update xiao rp2040 pins#5693
prplz wants to merge 0 commit into
adafruit:mainfrom
prplz:xiao-rp2040-pins

Conversation

@prplz
Copy link
Copy Markdown

@prplz prplz commented Dec 9, 2021

The schematic on the seeed website is incorrect/outdated. In reality there's an RGB LED connected to the pins as specified in this PR.
Tested on real hardware.

@Neradoc
Copy link
Copy Markdown

Neradoc commented Dec 9, 2021

If these are the components of an RGB LED, and not independent "red LED", "green LED" and "blue LED", I believe it is customary to call the components LED_R, LED_G, LED_B (or possibly LED_RED, LED_GREEN, LED_BLUE). There doesn't seem to be strong conventions though. This is how it's done on the Pimoroni Tinny 2040 for example:

{ MP_ROM_QSTR(MP_QSTR_LED_R), MP_ROM_PTR(&pin_GPIO18) },
{ MP_ROM_QSTR(MP_QSTR_LED_G), MP_ROM_PTR(&pin_GPIO19) },
{ MP_ROM_QSTR(MP_QSTR_LED_B), MP_ROM_PTR(&pin_GPIO20) },

Comment thread ports/raspberrypi/boards/seeeduino_xiao_rp2040/pins.c Outdated
@dhalbert dhalbert changed the base branch from main to 7.1.x December 9, 2021 14:13
@dhalbert dhalbert changed the base branch from 7.1.x to main December 9, 2021 14:13
@dhalbert
Copy link
Copy Markdown
Collaborator

dhalbert commented Dec 9, 2021

@prplz could you checkout 7.1.x instead and submit a new PR against that branch? Then it will get in the 7.1.0 beta series. Thank you.

@prplz
Copy link
Copy Markdown
Author

prplz commented Dec 9, 2021

Oops, force push made stuff go a little weird.

@prplz prplz closed this Dec 9, 2021
@prplz prplz deleted the xiao-rp2040-pins branch December 9, 2021 22:33
@prplz prplz mentioned this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants