Skip to content

nrf: Change pin names on DKs to match silkscreen#617

Merged
microbuilder merged 1 commit into
adafruit:masterfrom
arturo182:nrf_gpio_cleanup
Feb 13, 2018
Merged

nrf: Change pin names on DKs to match silkscreen#617
microbuilder merged 1 commit into
adafruit:masterfrom
arturo182:nrf_gpio_cleanup

Conversation

@arturo182
Copy link
Copy Markdown
Collaborator

@arturo182 arturo182 commented Feb 12, 2018

Revamped the make-pins.py script so it generates cleaner pin files which are used instead of the static board ones.

On the DKs you get PX_YY for both board and microcontroller.pin and on the feather52 you get silkscreen names like A0, D13 or SCK for board and PX_YY for microcontroller.pin.

Tested with digitalio and analogio modules.

Quite a big revamp of the make-pins script, it is now used on each
build to generate the pin files, so the static ones are not needed
anymore.
@microbuilder
Copy link
Copy Markdown

I need to get a bootloader PR in (likely later today) before the changes here, but I'll review and test this as soon as the nRF52840 serial bootloader PR is out.

@microbuilder
Copy link
Copy Markdown

BTW, if you put any new test code and examples together, feel free to include them in either the ports/nrf/examples folder or a board level examples folder if it's board specific.

I'm convinced a lot of people look directly at the code repo and examples that ship with it as their first point of contact, so having up to date examples there makes sense to me, and being in the repo generally increases the chance of them being up to date with the latest API changes, especially with things like BLE.

@arturo182
Copy link
Copy Markdown
Collaborator Author

Out of curiosity, why is the BL needed before this?

@microbuilder
Copy link
Copy Markdown

Because it will add another board to the repo that will need to be updated as well, and will create a conflict. I can merge this one in as well and the conflict will be in the BL PR, it just needs to be handled in one of them but I've had my head down in code all day and haven't had a chance to try this one out so I was going to submit the BL PR for review, and then find a solution to keep both of these happy.

If you want to get this in right away, I'll test it later tonight and manage the conflict in the BLE PR though.

Copy link
Copy Markdown

@microbuilder microbuilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll manage the changes in the bootloader PR, which introduces a new board option (feather52840).

@microbuilder microbuilder merged commit fac488f into adafruit:master Feb 13, 2018
@arturo182 arturo182 deleted the nrf_gpio_cleanup branch February 14, 2018 06:57
@arturo182
Copy link
Copy Markdown
Collaborator Author

Ah, interesting to see a nRF52840 feather coming, I guess I got my changes in just in time for you guys ;)

@microbuilder
Copy link
Copy Markdown

It's just a shell on top of the PCA10056 for now until modules are available, but since this one will have a different flash layout I figured I may as well make a new board now rather than complicating the PCA10056 BSP. No ETA on when a proper board will be out, we still don't have any modules available since the final chips haven't been released yet. Thanks for the numerous PRs, though! It really helps having another sets of hands and eyes!

@arturo182
Copy link
Copy Markdown
Collaborator Author

What do you mean no modules available, how do you call this then? https://twitter.com/arturo182/status/951567482921332736 😂

@microbuilder
Copy link
Copy Markdown

There are early engineering samples available of chips, yes, but we need FCC approved modules of the final silicon, which is still a little ways out, and the final tapeout for the release silicon I believe hasn't happened yet (very soon), even though a couple generations of chips have been released to customers and early adopters for development.

@microbuilder
Copy link
Copy Markdown

See here, for example, which is less than a month ago: https://devzone.nordicsemi.com/f/nordic-q-a/29833/nrf52840-production-dates

@arturo182
Copy link
Copy Markdown
Collaborator Author

Yes, I am aware of all of this, I've been in contact with Nordic as well, was just joking around cause that's a module I designed and assembled 😄

@microbuilder
Copy link
Copy Markdown

Ah, sorry ... clearly my humor gene is recessive 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants