Save flash space by defining atan() in terms of atan2()#6704
Closed
jepler wants to merge 1 commit into
Closed
Conversation
I noticed that atanf() and atan2f() were both pretty bulky functions. It's a definition that atan2f(y,1f) == atanf(y). However, the performance optimization that atan2f(y,1f) can be computed in this way has to also be removed.
Author
|
On trinket_m0 this saves 488 bytes. |
Author
|
huh but it doesn't work. I tested on esp32s3 and now atan(any arguments) or atan2(any arguments) crashes instead. |
Author
|
I missed that atan2f called atanf in two places, not just one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that atanf() and atan2f() were both pretty bulky functions. It's a definition that atan2f(y,1f) == atanf(y). However, the performance optimization that atan2f(y,1f) can be computed in this way has to also be removed.