Skip to content

Latest arch uncrustify#7714

Closed
bill88t wants to merge 3 commits into
adafruit:mainfrom
bill88t:latest-uncrustify
Closed

Latest arch uncrustify#7714
bill88t wants to merge 3 commits into
adafruit:mainfrom
bill88t:latest-uncrustify

Conversation

@bill88t
Copy link
Copy Markdown

@bill88t bill88t commented Mar 11, 2023

Docs specify no uncrustify version.
Arch:latest provides version Uncrustify_d-0.75.1_f which produces the following during pre-commit run --all

Copy link
Copy Markdown
Collaborator

@microdev1 microdev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are limited by the uncrustify version in MicroPython. Changing ours will complicate a merge from upstream.
The docs mention this version limitation.

@bill88t
Copy link
Copy Markdown
Author

bill88t commented Mar 11, 2023

Thanks and sorry for missing that.

@bill88t bill88t closed this Mar 11, 2023
@bill88t bill88t deleted the latest-uncrustify branch March 11, 2023 14:01
@tannewt
Copy link
Copy Markdown
Member

tannewt commented Mar 13, 2023

@bill88t I have a version of uncrustify 0.72 if you need it. I think we're also limited by what Ubuntu packages because that's what the CI uses.

@bill88t
Copy link
Copy Markdown
Author

bill88t commented Mar 13, 2023

Aur has a nice package named downgrade, it got me to 0.71 in the blink of an eye. Thanks for the offer though.

@tannewt
Copy link
Copy Markdown
Member

tannewt commented Mar 14, 2023

Thanks for the tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants