Re-enable PDMIn without ASF#789
Merged
Merged
Conversation
I2SOut. The API is almost the same except the frequency attribute has been renamed to sample_rate so that its less likely to be confused with frequencies within the audio itself. Fixes micropython#263.
dhalbert
reviewed
May 2, 2018
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
This looks really good, and the CMSIS level of progarmming is actually surprisingly refreshing.
Two q's:
-
You increased SAMPLES_PER_BUFFER to 64. Is this just for throughput? I was keeping it lower due to SAMD21 RAM size, but maybe it's OK.
-
Have you tried it on a CPX the builtin mic with small and larger buffer sizes, sampling freqs, and 8 vs 16 bit? This was crucial for me to make sure it was keeping up.
Collaborator
|
Tried Also tried a 2000-byte buffer. Same thing. |
Member
Author
|
Ok thanks for testing it! I had only tested on the metros with 16-bit. I'm looking into it now. |
The DMA trigger source was incorrect when using serializer 1 on the SAMD21. Playback register was incorrect for 8 bit as well. Now fixed.
dhalbert
approved these changes
May 2, 2018
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Woot! Tested and works great on CPX! I'm getting the same kind of numbers as 2.2.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API is almost the same except the
frequencyattribute has beenrenamed to
sample_rateso that its less likely to be confused withfrequencies within the audio itself.
Fixes #263.