allow esptool.py invocation to be set via make vars#794
Merged
Conversation
This commit replaces the literal calls to `esptool.py` with the
`$(ESPTOOL)` Makefile variable. This allows one to set the esptool
invocation on the Make command line:
make ESPTOOL="python2 $(which esptool.py)"
(or via the environment, an include file, etc)
Closes micropython#793
tannewt
approved these changes
May 2, 2018
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Awesome! Thank you for the helpful change.
larsks
added a commit
to larsks/docker-image-esp-open-sdk
that referenced
this pull request
May 2, 2018
the circuitpython (https://github.com/adafruit/circuitpython) Makefiles expect both `which` and `git` to be available. Also addressed on the other side by adafruit/circuitpython#792 and adafruit/circuitpython#794.
larsks
added a commit
to larsks/docker-image-esp-open-sdk
that referenced
this pull request
May 2, 2018
the circuitpython (https://github.com/adafruit/circuitpython) Makefiles expect both `which` and `git` to be available. Also addressed on the other side by adafruit/circuitpython#792 and adafruit/circuitpython#794.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit replaces the literal calls to
esptool.pywith the$(ESPTOOL)Makefile variable. This allows one to set the esptoolinvocation on the Make command line:
(or via the environment, an include file, etc)
Closes #793