ports/esp8266: optionally include local Makefile settings#798
Conversation
This commit modifies the Makefile so that it will load the file `local.mk` if it exists. This permits one to persistently set things like port, speed, and flash mode. This is the same as micropython#3757.
|
In |
|
@dhalbert I think it's helpful to have something that is strictly for private local use, because otherwise you're going to be committing "private local changes" by accident, all the time. Or losing them. |
|
In that case, are you putting |
|
I hadn't thought about it, but that's a good idea. |
|
Also! Should it be near the top of the file (e.g., at the same place as you have |
|
Near the top, so it can influence stuff below. But can I ask, do you already have your own private repo that you're modifying, or are you using stock esp8266 most of the time? You can always make this change yourself and just merge from upstream as necessary. I am not sure Damien would accept the change because he would suggest the above. Also one would want this across ports and it's only in esp8266 now. I make local changes to Makefile all the time (like turning off inlining for debugging purposes). I just have to be careful not to commit that stuff upstream. |
|
I just hate making private changes to files that are owned by the repository. But eh, I'm not going to fight for it :) |
2 participants
This commit modifies the Makefile so that it will load the file
local.mkif it exists. This permits one to persistently set thingslike port, speed, and flash mode.
This is the same as micropython#3757.