Skip to content

EFR32-related doc fixes#7989

Closed
applecuckoo wants to merge 4 commits into
adafruit:mainfrom
applecuckoo:main
Closed

EFR32-related doc fixes#7989
applecuckoo wants to merge 4 commits into
adafruit:mainfrom
applecuckoo:main

Conversation

@applecuckoo
Copy link
Copy Markdown

Mainly typos, I also added a silabs entry to the supported ports. Let me know if anything should be reworded. Thanks!

@applecuckoo applecuckoo marked this pull request as draft May 17, 2023 04:37
Copy link
Copy Markdown
Author

@applecuckoo applecuckoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the things that I need feedback on:

Comment thread ports/silabs/README.md
![Thony](./res/Thony.png)
![Thonny](./res/Thonny.png)

With the boards which support USB mass storage, we can drag the files to the board file system. However, because the EFR32 boards don’t support USB mass storage, we need to use a tool like **Ampy** to copy the file to the board. You can use the latest version of **Ampy** and its  command to copy the module directories to the board.
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the use of Ampy here, it's currently maintained by @scientifichackers but the attached learn guide seems outdated. Not sure if there's anything we can do here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally we suggest Thonny now.

Comment thread ports/silabs/README.md
## Running CircuitPython ##

### Getting a REPL prompt ###
### Connecting to the Serial Console ###
Copy link
Copy Markdown
Author

@applecuckoo applecuckoo May 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed this based on the Welcome to CircuitPython guide, anything better that I could rename this to?

Comment thread README.rst Outdated
Co-authored-by: MicroDev <70126934+microdev1@users.noreply.github.com>
@applecuckoo applecuckoo marked this pull request as ready for review May 18, 2023 08:18
@applecuckoo
Copy link
Copy Markdown
Author

Okay, messed this up by not working on a branch. Will open a brand new PR once I sort this out...

@applecuckoo
Copy link
Copy Markdown
Author

Succeeded by #8042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants