Skip to content

PBxx pins were not setting DRVSTR or reporting PULL properly#827

Merged
tannewt merged 1 commit into
adafruit:masterfrom
dhalbert:3.0_pb_pins_digitalinout
May 11, 2018
Merged

PBxx pins were not setting DRVSTR or reporting PULL properly#827
tannewt merged 1 commit into
adafruit:masterfrom
dhalbert:3.0_pb_pins_digitalinout

Conversation

@dhalbert
Copy link
Copy Markdown
Collaborator

@dhalbert dhalbert commented May 11, 2018

Forgot to mask pin number for certain hri calls. PBxx pins were not getting DRVSTR set to strong properly or reporting their pull properly.

Fixes #823

@dhalbert dhalbert requested a review from tannewt May 11, 2018 03:11
Copy link
Copy Markdown
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! Thanks!

@tannewt tannewt merged commit 51106db into adafruit:master May 11, 2018
@dhalbert dhalbert deleted the 3.0_pb_pins_digitalinout branch June 15, 2018 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants