New UM boards setup for 9.x#8502
Closed
UnexpectedMaker wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Seon Rozenblum <seon@unexpectedmaker.com>
tannewt
requested changes
Oct 23, 2023
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Please try qio for quad io to the flash. In dio was only used for flashing. Now it controls the speed it actually executes at. qio flashing gets automatically downgraded to dio now.
Author
|
Hey @tannewt - Sorry for the delay in replying, been busy making hardware all week. Sure, I'll change this and get the PR updated. |
Signed-off-by: Seon Rozenblum <seon@unexpectedmaker.com>
tannewt
reviewed
Oct 30, 2023
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Looks good but it looks like you'll need to merge main into this. (Maybe the 8.2.x versions of these boards were merged in with 8.2.7)
Collaborator
|
Closing this as superseded by #8575, but no problem with a new PR that adjusts things slightly as needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated files for new Unexpected Maker boards to make them conform with new sdkconfig setup