Skip to content

RTD documentation updates#863

Merged
tannewt merged 6 commits into
adafruit:masterfrom
dhalbert:3.0_doc_updates
May 23, 2018
Merged

RTD documentation updates#863
tannewt merged 6 commits into
adafruit:masterfrom
dhalbert:3.0_doc_updates

Conversation

@dhalbert
Copy link
Copy Markdown
Collaborator

This is meant to address the documentation shortcomings in #328. There's more work that could be done on the documentation, but I'm trying to bring it somewhat more up to date.

More work needs to be done after renaming more builtin modules to drop the "u" prefix.

@dhalbert dhalbert requested a review from tannewt May 22, 2018 23:54
Copy link
Copy Markdown
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this! I'm a stickler on a number of these core modules and would like to mark them unsupported until we restructure their docs and make sure they match CPython's use.

Comment thread README.rst Outdated
- tracks MicroPython's releases (not master).
- Longints (arbitrary-length integers) are turned on for most Express builds
(those boards with SPI flash chips external to the microcontroller),
but not for boards without SPI flash, for space reasons.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have express stuff in M4 non-express right? Should we target 256kb binary size for them? I think thats what I have setup now.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, didn't think of M4-non-Express.

Comment thread docs/library/array.rst
@@ -1,8 +1,6 @@
:mod:`array` -- arrays of numeric data
======================================

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to have these docs inline rather than in files separate from the implementation. Until then I'd like to call them unsupported because its hard to keep them up to date.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reluctant to call them unsupported. To me that means you shouldn't use them, or that we wouldn't fix bugs in them. If you want to say that they may change in the future, that seems more like what you want to imply. But we couldn't write a lot of useful code without struct, array, sys, os, etc. in our libraries and use them in Learn Guides, so maybe something milder than "unsupported".

Comment thread docs/library/gc.rst
:class: attention

This function is MicroPython extension.
This function is a MicroPython extension.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not call gc supported until we move the extensions out of here.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The functionality of gc may change in the future to more closely match that of CPython."

@dhalbert
Copy link
Copy Markdown
Collaborator Author

I didn't restore the word "unsupported", but I added some stronger caveats about using the MicroPython-derived libraries. See if this matches your intent.

tannewt
tannewt previously approved these changes May 23, 2018
Copy link
Copy Markdown
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new warning is great! Thanks!

Copy link
Copy Markdown
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is failing because struct.rst is duplicating shared-bindings/struct. Should be as easy as removing struct.rst.

Copy link
Copy Markdown
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@tannewt tannewt merged commit 8e6feec into adafruit:master May 23, 2018
@dhalbert dhalbert deleted the 3.0_doc_updates branch June 2, 2018 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants