Revert "Use specific pid for Flipper Wifi"#8745
Closed
dhalbert wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Canceled the build for this, because it's a waste of time. |
Collaborator
Author
|
Alright, I won't revert now, but @maewolfsky, please submit a new PR with the PID that Espressif has assigned after the conflict in their repo is resolved. |
|
I'll just delete the pr; again, Flipper Devices Inc are the ones that never requested from espressif |
Collaborator
Author
|
@maewolfsky so would it be best to revert your PR? Go ahead and submit a new PR that is a revert from your repo. Otherwise the revert builds everything twice (if it's not from a fork). Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@maewolfsky Reverting.
The PID was not assigned by espressif yet. See espressif/usb-pids#129, which conflicts with espressif/usb-pids#128.
Could you submit a new PR after Espressif has approved the newly assigned PID?