Skip to content

Ad Led_IR pin name to ATOM Lite#8746

Closed
carson-coder wants to merge 1 commit into
adafruit:mainfrom
carson-coder:main
Closed

Ad Led_IR pin name to ATOM Lite#8746
carson-coder wants to merge 1 commit into
adafruit:mainfrom
carson-coder:main

Conversation

@carson-coder
Copy link
Copy Markdown

Try to fix issue #8738 by adding gpio 12 as the IR light and D12

Fix issue adafruit#8738 from circuitpython
@carson-coder
Copy link
Copy Markdown
Author

This is untested because I don't have the atom_lite so this may want to be tested before merging

@dhalbert dhalbert linked an issue Dec 21, 2023 that may be closed by this pull request
@dhalbert dhalbert changed the title Fix #8738 Ad Led_IR pin name to ATOM Lite Dec 21, 2023
@dhalbert
Copy link
Copy Markdown
Collaborator

@sctv is this what you had in mind?

@carson-coder two things:

  1. If you do this against 8.2.x instead of main then it can get into the next 8.2.x release. You would make the change off a branch that is branched from 8.x.2. The board is available in 8.2.x. Then we will merge it to main when we catch up main to 8.2.x.
  2. You made this change on your main branch. It's generally better to create a new branch off the dev branch (in this case, either main or 8.2.x). Otherwise your main or 8.2.x branch will get out of sync with the adafruit upstream repo that you forked from. See https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github/always-work-on-a-branch for a discussion.

@carson-coder
Copy link
Copy Markdown
Author

Ok. I will try to make a branch to change 8.2.x and change or make a new pull request.

@carson-coder carson-coder marked this pull request as draft December 21, 2023 23:29
@carson-coder carson-coder deleted the main branch December 22, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ad Led_IR pin name to ATOM Lite ESP32 circuitpython

2 participants