Alternative fix for "espulp module broken in CircuitPython 9"#9282
Closed
Sola85 wants to merge 11 commits into
Closed
Alternative fix for "espulp module broken in CircuitPython 9"#9282Sola85 wants to merge 11 commits into
Sola85 wants to merge 11 commits into
Conversation
|
Circuitpython has it's own fork of idf. |
Author
|
Ah, good to know. Then I will propose a change enabling the use both ulps simultaneously in that repo instead! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to PR #9277. In that PR, this issue in the esp-idf was circumvented by disabling one of the ULPs for every type of esp32.
Here, instead we copy one file (namely
ports/espressif/bindings/espulp/ulp_riscv.c) from the esp-idf into the circuitpython repo, in order to make the necessary functions for the riscv ulp available at compile time (as suggested by @tannewt here).This allows both the FSM and RISCV ulps to be included simultaneously in circuitpython for ESP32S2/S3 despite the above issue in esp-idf.
We also have to define
CONFIG_ULP_COPROC_TYPE_RISCVmanually based on whichCONFIG_IDF_TARGET_ESP32XXis set.Since I'm not sure whether copying a file from esp-idf into the circuitpython repo is acceptable for the maintainers, I have created a separate PR for this commit.
Here is a small proof of concept, showing that the RISCV ULP works again, after this PR