nrf: Rewrite the SPI common-hal using nrfx#959
Merged
Conversation
Use SPIM2 on nRF52832 and SPIM3 on nRF52840. SPIM3 is able to go up to 32MHz!
Member
|
Superb, I think we should re-implement all the driver with nrfx. So that we don't need to maintain it ourself. I will help later on after the usb boot things. Their prph code isn't opensource friendly at the start and too tightly couple with sdk until recently. |
Collaborator
Author
|
That is my plan :) |
tannewt
approved these changes
Jun 26, 2018
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Cool! This new library looks nice!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use SPIM2 on nRF52832 and SPIM3 on nRF52840. SPIM3 is able to go
up to 32MHz!