Documentation for Client.py (API Client)#78
Merged
Conversation
jerryneedell
requested changes
Dec 31, 2018
jerryneedell
left a comment
jerryneedell
left a comment
There was a problem hiding this comment.
I have one concern about a potential breaking change. I think this requires some updates to the examples.
jerryneedell
approved these changes
Dec 31, 2018
jerryneedell
left a comment
jerryneedell
left a comment
There was a problem hiding this comment.
Looks good to me. I recommend a note in the release notes about the breaking change to send_location_data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup of
client.py, the API Client for IO: