Followup ghostfat test#104
Merged
Merged
Conversation
Collaborator
|
OK, will review.... |
henrygab
approved these changes
Mar 24, 2021
Collaborator
henrygab
left a comment
henrygab
left a comment
There was a problem hiding this comment.
Well done! Just two minor questions. I can approve now, as they are so minor.
Member
Author
|
thank you for reviewing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #94 to separate native build tests from cross-compile (for target hardware).
NO_TINYUF2_BUILDis used for this purpose (along with SKIP_NANOLIB, some later ports especially non-ARM may skip this lib as well). NO_TINYUF2_BUILD introduced in recent PR to allow make.mk and rule.mk to build other executable image such aserase_firmware(will also migrate self_update later on).Eventually, test_ghostfat/main.c run on its own and interact with a small subset of board_api, those that are used by ghostfat.c.
PS: I really like this and want to move this to its own unit tests folder, maybe later. Got to catch up with iMXRT board release https://www.adafruit.com/product/4950