mimxrt10xx: Also self-install when FCFB not valid#109
Merged
Conversation
hathach
reviewed
Apr 12, 2021
Member
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
Look good, though could you merge these 2 into 1 if. We can skip the log. It is not really needed.
if ( (boot_mode == 1) || !fcfb_valid)
{
write_tinyuf2_to_flash();
}
hathach
approved these changes
Apr 12, 2021
Member
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
perfect, thank you for the ci cache fix as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When starting with a blank flash chip, the board will enter sdp bootloader mode even if the jumpers are in the FlexSPI boot position. However, since b28b83a, tinyuf2 would not write itself to flash in this situation. Make it do so in both the "boot switch" or "fcfb invalid" cases.