Added bootloader for Muse Lab nanoESP32-S2#120
Conversation
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
look good, you should also include the board in the ci so that it is built and binary is released
|
Oops, I forgot that, it should be good now :) |
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
UF2_VOLUME_LABEL has limit of 11 characters, it will get truncated, you may want to test it or rename it
|
|
||
| #define UF2_PRODUCT_NAME USB_MANUFACTURER " " USB_PRODUCT | ||
| #define UF2_BOARD_ID "ESP32S2-nanoESP32-S2-WROOM-v1.2" | ||
| #define UF2_VOLUME_LABEL "NANOESP32S2WROOMBOOT" |
There was a problem hiding this comment.
uf2 label is too long it will be truncated to 11 character, do you want to have it rename ?
There was a problem hiding this comment.
hmm, I was a little optimistic about it, if we want to keep an explicit name I think the 2 variants will have the same volume name. My proposal in the commit below.
|
|
||
| #define UF2_PRODUCT_NAME USB_MANUFACTURER " " USB_PRODUCT | ||
| #define UF2_BOARD_ID "ESP32S2-nanoESP32-S2-WROVER-v1.2" | ||
| #define UF2_VOLUME_LABEL "NANOESP32S2WROVERBOOT" |
There was a problem hiding this comment.
uf2 label is too long it will be truncated to 11 character, do you want to have it rename ?
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
look good now, thanks for the pr
2 participants
Added bootloader for both versions of Muse Lab nanoESP32-S2, WROOM and WROVER.
A PID was assigned by Adafruit for the WROOM version, I got the PID for WROVER version from Espressif.