Skip to content

add support to 2 boards#122

Closed
CircuitART wants to merge 10 commits into
adafruit:masterfrom
CircuitART:master
Closed

add support to 2 boards#122
CircuitART wants to merge 10 commits into
adafruit:masterfrom
CircuitART:master

Conversation

@CircuitART
Copy link
Copy Markdown
Contributor

@CircuitART CircuitART commented Jun 14, 2021

Hi please add support to my 2 new boards: circuitart_esp32s2core & circuitart_stm32f4core

thx

@CircuitART CircuitART closed this Jun 14, 2021
@CircuitART CircuitART reopened this Jun 14, 2021
hathach
hathach requested changes Jun 14, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good, there is only a couple of requests (check out comment). Also as part of VID/PID requirement, could you tell how you obtain the VID/PID for your boards.

Comment thread ports/esp32s2/boards/circuitart_esp32s2core/board.h Outdated
Comment thread ports/stm32f4/boards/circuitart_stm32f4core/board.h Outdated
Comment thread .github/workflows/build.yml Outdated
Comment thread ports/esp32s2/boards/circuitart_esp32s2core/board.h Outdated
@CircuitART
Copy link
Copy Markdown
Contributor Author

CircuitART commented Jun 14, 2021 •
edited
Loading

look good, there is only a couple of requests (check out comment). Also as part of VID/PID requirement, could you tell how you obtain the VID/PID for your boards.

from the repo of pid.codes, but still have not created a pull request yet, as i still have 3 other boards that i am preparing files for

CircuitART
CircuitART commented Jun 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@CircuitART CircuitART left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

board ID has been corrected in both board.h files, also website has this comment now (// TODO update link)
build.yml abc order has been corrected
VID/PID are from pid.codes but the pull requested has not been made yet

@hathach
Copy link
Copy Markdown
Member

hathach commented Jun 14, 2021

board ID has been corrected in both board.h files, also website has this comment now (// TODO update link)
build.yml abc order has been corrected
VID/PID are from pid.codes but the pull requested has not been made yet

Can you give link to the PR, we will merge once that PR is merged.

@CircuitART
Copy link
Copy Markdown
Contributor Author

CircuitART commented Jun 16, 2021

board ID has been corrected in both board.h files, also website has this comment now (// TODO update link)
build.yml abc order has been corrected
VID/PID are from pid.codes but the pull requested has not been made yet

Can you give link to the PR, we will merge once that PR is merged.

ok thanks I will update the pull request with PID.CODES PR link

@hathach
Copy link
Copy Markdown
Member

hathach commented Jun 16, 2021

board ID has been corrected in both board.h files, also website has this comment now (// TODO update link)
build.yml abc order has been corrected
VID/PID are from pid.codes but the pull requested has not been made yet

Can you give link to the PR, we will merge once that PR is merged.

ok thanks I will update the pull request with PID.CODES PR link

I mean can you give the link to the PID.CODES PR link here in the comment section, adding it to the code is optional and up to you.

@hathach hathach marked this pull request as draft December 25, 2021 06:44
@CircuitART CircuitART closed this Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hathach hathach hathach requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CircuitART @hathach