esp_reset_reason_set_hint() replacement by NVS flag (ESP32-S2)#128
Closed
T94T wants to merge 8 commits into
Closed
esp_reset_reason_set_hint() replacement by NVS flag (ESP32-S2)#128T94T wants to merge 8 commits into
T94T wants to merge 8 commits into
Conversation
Update README.md
Update bootloader_start.c
Update CMakeLists.txt
Update Makefile
Author
|
will prepare the pull request again. |
Member
|
@T94T I dived a bit into this, there is no need for using NVS, the reason hint is still accessible within stage2 bootloader. IDF just slightly changes the reset reason for esp_restart(). I will make an PR to correct this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
esp_reset_reason_set_hint()is not working/supported anymore (see: espressif/esp-idf#7230) I decided to rewrite the corresponding code using NVS storage instead.Please note that this pull request does not work at the moment. There is still a compilation error:
I hope someone can fix this.