Added support for my new FeatherS2 Neo#133
Merged
Merged
Conversation
Added FeatherS2 Neo to build script
hathach
reviewed
Jul 15, 2021
hathach
requested changes
Jul 15, 2021
Member
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
Board id must follow the uf2 specs, please correct
The Board-ID field is machine-readable and consists of a number of dash-separated tokens. The first token is the CPU type, second is the board type, and third is the board revision. More tokens can be also added.
hathach
approved these changes
Jul 15, 2021
Member
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
great! Thank you for your pr, yeah I try to enforce the board id specs since it is common mistake from user. Sometimes I forgot about it as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also remembered to dded FeatherS2 Neo to build script this time :)
VID/PID is from Espressif:
https://github.com/espressif/usb-pids/blob/main/allocated-pids.txt
Cheers :)