Added support for I2C power control during boot2 phase#150
Conversation
|
Initializing the TCA9554 using software I2C |
| static void board_led_off(void) | ||
| { | ||
| #ifdef NEOPIXEL_PIN | ||
| delay_cycle( ns2cycle(1000*1000) ) ; |
There was a problem hiding this comment.
is there any reason that you move the delay before the neopixel off ? would the pixel is off when the delay is as it is ? Otherwise please move it back to its original location.
There was a problem hiding this comment.
I'll wait until you have pushed whatever changes you have made. You are correct in that it works either way and should be after. This is a remnant from trying to eliminate what I thought was a problem. Thanks
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
I have made some changes to the PR, but couldn't push it to your fork to update this PR due to permission. Please set your fork to allow maintainer to have write permission, or simply grant me write permission
I have invited you as a collaborator on my fork. Hopefully this is what you are asking for. Thanks for looking at the PR |
thanks for the invitation, actually, I just fiugred out I made an typo in the push command previously. Anyway, I pushed the changes, mostly some format clean up along with the macro for NEOPIXEL_RESET_DELAY set to 1000 us for using gpio expander, 200us for existing boards. |
| delay_cycle( NEOPIXEL_RESET_DELAY ) ; | ||
|
|
||
| // Neopixel reset time |
There was a problem hiding this comment.
the delay should be below its comment. But I push update for this change already.
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
Thank you for your PR, everything look perfect now. Will merge when ci is passed.
2 participants
Added support for I2C TCA9554 peripheral power control during the boot2 phase.
Uses software I2C.
Made a small change to the neopixel reset timing (increased to 1000usec) as it seems to be needed on this board.
I tested this timing with another neopixel equipped board (Gravitech Cucumber) and it worked.