Fix build on rp2040#80
Merged
Merged
Conversation
Member
|
It is indeed a small change, though since rp2040 support uf2 in bootrom. I am not sure whether we will ever port it into this repo. Are you doing rp2040 ? |
Contributor
Author
|
We're using this to flash a peripheral that's connected to an rp2040. Not rp2040 itself. (Uploading our tool to the rp2040 in no_flash mode, flashing our peripheral, and then rebooting back into rp2040 bootrom.) Greatly simplifies workflow. :) |
hathach
approved these changes
Mar 7, 2021
Member
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
Thanks for the context, look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just the small changes needed to make it work. Using this to flash a peripheral.