Allow overriding the compilation date/time#91
Merged
Conversation
hathach
reviewed
Mar 14, 2021
Member
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
the name is too long how about changing it to FAT_DATE and FAT_TIME, there is no need for underscore since these aren't system macro. In case of conflict we could add TUF2_ prefix.
Collaborator
Author
|
All macros are now have the prefix |
hathach
approved these changes
Mar 15, 2021
Member
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
thank you, it looks perfect now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to simplify the process of generating repeatable ghostfat images from tests.
Supporting this will help automate validation that the resulting image files are unchanged.