Skip to content

Conversation

@LucianBuzzo
Copy link

No description provided.

@LucianBuzzo
Copy link
Author

@wdavidw Any chance of getting this small fix merged?

@wdavidw
Copy link
Member

wdavidw commented Nov 28, 2025

Actually, the doc is correct, 1 emit the first record. Probably we shall clarify the behavior. For example, a value of 2 omit the first record and emit the second record.

@LucianBuzzo
Copy link
Author

Whoop! I had to re-read the documentation a number of times for that to sink in 😅 - I can take a crack at clarifying the behaviour.

@wdavidw
Copy link
Member

wdavidw commented Nov 28, 2025

I am on it, give me 2mn and I'll propose something (it is about to be committed, just doing some markdown formating before).

@wdavidw
Copy link
Member

wdavidw commented Nov 28, 2025

This is what I propose:

The from option handles records starting from a requested number of records. Count is 1-based, for example, provides 2 (and not 1) to omit first record and emit the second record.

@LucianBuzzo LucianBuzzo changed the title fix typo in docs for from option fix(parse): clarify documentation for from option Nov 28, 2025
@LucianBuzzo
Copy link
Author

Hi @wdavidw I just saw your message here as I pushed an update to this PR - let me know what you think.

@wdavidw
Copy link
Member

wdavidw commented Nov 28, 2025

Thank you @LucianBuzzo for your suggestion, I'll keep my formulation (I find it shorted).

@wdavidw wdavidw closed this in ffaa054 Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants