Skip to content

type hints no longer break parser#36

Merged
adambullmer merged 7 commits intoadambullmer:masterfrom
EdsterG:bugfix/ignore_type_hints
Sep 26, 2018
Merged

type hints no longer break parser#36
adambullmer merged 7 commits intoadambullmer:masterfrom
EdsterG:bugfix/ignore_type_hints

Conversation

@EdsterG
Copy link
Copy Markdown
Contributor

@EdsterG EdsterG commented Sep 21, 2018 •
edited
Loading

Parse type hints and use them to auto file types. Fixes #33 and fixes #34.

@EdsterG
Copy link
Copy Markdown
Contributor Author

EdsterG commented Sep 25, 2018

Just realized, the regex in parse_arguments can be simplified once #39 is merged.

@EdsterG
Copy link
Copy Markdown
Contributor Author

EdsterG commented Sep 25, 2018

Never mind, split_by_commas doesn't keep a stack of opening/closing brackets so it doesn't work correctly for nested brackets. Once that's fixed, then the regex can be simplified quite a bit.

@adambullmer adambullmer merged commit 434e8f1 into adambullmer:master Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doesn't work with return type hinting doesn't work with argument type hinting

2 participants

@EdsterG @adambullmer