Add support for browsers that use the WebExtension API #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adambullmer
reviewed
Aug 25, 2018
| entries.contentScript = 'content-script' | ||
| } | ||
|
|
||
| const ChromeExtensionReloader = require('webpack-chrome-extension-reloader') |
Owner
There was a problem hiding this comment.
Awesome work and thanks for taking the time to contribute. For full transparency, I'm probably going to keep this import at the top of the file so that all dependencies are in one place and explicit. But I didn't feel that it was necessary to block your PR from getting merged to accomplish that.
This was referenced Aug 25, 2018
Merged
siphomateke
added a commit
to siphomateke/vue-cli-plugin-browser-extension
that referenced
this pull request
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following prompts are added: