[pull] main from containerd:main#305
Merged
Merged
Conversation
Under slow network conditions (e.g., simulated 2 Mbps ingress bandwidth limits in CI), restoring a container from a checkpoint can fail if it requires pulling the base image again. During restore, crictl create is called. In test_from_oci, it used a 10-second timeout (crictl -t 10s create). Over a 2 Mbps connection, pulling the 2.8MB Alpine layer takes ~12-13 seconds, causing the operation to exceed the timeout and fail with context canceled. Increase the timeouts in both test_from_archive and test_from_oci to 30 seconds. This ensures the base image pull can complete successfully even in constrained CI environments. Tested: Ran the CRI integration tests on a GCE VM under a simulated 2 Mbps ingress bandwidth limit using traffic control (tc). Verified that both test_from_archive and test_from_oci passed successfully and container restore completed without timeout. Assisted-by: Antigravity Signed-off-by: Samuel Karp <samuelkarp@google.com>
contrib/checkpoint: increase timeouts to 30s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )