Added ignore option #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreisnz
requested changes
Aug 24, 2017
Owner
adamreisnz
left a comment
adamreisnz
left a comment
There was a problem hiding this comment.
Hi @kodie, thanks for the PR! Could you please address the two comments? Rest looks good!
|
|
||
| //Get from/to parameters from CLI args if not defined in config file | ||
| if (typeof from === 'undefined') { | ||
| from = argv._.shift(); |
Owner
There was a problem hiding this comment.
We have to use shift here because we can't be sure of the index. For example, from might be defined in the config already, and then it's not shifted, but then to will be in position 0.
bin/cli.js
Outdated
| //Get files | ||
| if (!files) { | ||
| files = argv._; | ||
| files = argv._[2]; |
Owner
There was a problem hiding this comment.
This is also a breaking change, people might rely on this functionality.
I would prefer to not pass the ignore files via the CLI but rather use the config file, or a named parameter, e.g. --ignore
Contributor
Author
|
@adamreisnz How's that? |
adamreisnz
approved these changes
Aug 24, 2017
Owner
adamreisnz
left a comment
adamreisnz
left a comment
There was a problem hiding this comment.
Looks good, thanks! I'll merge it in shortly.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves Issue #26.