Skip to content

Conversation

@jdcrecur
Copy link
Contributor

@jdcrecur jdcrecur commented Mar 5, 2018

No description provided.

@coveralls
Copy link

coveralls commented Mar 5, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 478b822 on jdcrecur:master into 33dfe50 on adamreisnz:master.

@adamreisnz
Copy link
Owner

Hi, thanks for your contribution! Just one comment, you don't always need sudo to install npm packages globally. This would depend on the OS you're on and the user you're running under.

As such, I prefer to leave it out of the documentation, as users will likely be able to figure this out, and I don't want to encourage everyone to use sudo unnecessarily.

Rest looks good!

@jdcrecur
Copy link
Contributor Author

jdcrecur commented Mar 6, 2018

Removed. It is a great util tool but i missed the global option hence me creating a TOC for the readme, hopefully might help others see the cli options.

@adamreisnz
Copy link
Owner

Brilliant, thank you!

@adamreisnz adamreisnz merged commit 153dc27 into adamreisnz:master Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants