Replace deprecated FileDescriptor.Syntax with Edition API#115
Merged
Conversation
FileDescriptor.Syntax and getSyntax() are deprecated in protobuf-java. Use FileDescriptor.getEdition() with Edition.EDITION_PROTO2 instead. https://claude.ai/code/session_01GuS3gDAhyroj3CfeC6bF7c
FileDescriptor.getEdition() returns EDITION_UNKNOWN for proto2 files
compiled with protoc 3.x since the edition field is not populated.
Use FileDescriptorProto.getSyntax() which returns the syntax string
directly ("proto2", "proto3", "editions") and is not deprecated.
https://claude.ai/code/session_01GuS3gDAhyroj3CfeC6bF7c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileDescriptor.Syntax and getSyntax() are deprecated in protobuf-java.
Use FileDescriptor.getEdition() with Edition.EDITION_PROTO2 instead.
https://claude.ai/code/session_01GuS3gDAhyroj3CfeC6bF7c